fix: Default preference value for receiveLoginDetectionEmail#35467
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Mar 13, 2025
Merged
fix: Default preference value for receiveLoginDetectionEmail#35467kodiakhq[bot] merged 6 commits intodevelopfrom
receiveLoginDetectionEmail#35467kodiakhq[bot] merged 6 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 261c029 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yash-rajpal
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
tiagoevanp
approved these changes
Mar 11, 2025
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35467 +/- ##
========================================
Coverage 59.64% 59.64%
========================================
Files 2827 2827
Lines 68511 68511
Branches 15183 15183
========================================
Hits 40862 40862
Misses 25001 25001
Partials 2648 2648
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
yash-rajpal
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
MarcosSpessatto
approved these changes
Mar 11, 2025
yash-rajpal
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently, on the server side, the default value for this preference is
truewhile on client side the default value is being shown as false.This creates a confusion between the actual and expected behavior.
To keep with this current behavior, this PR updates the default value on client side to be true.
Issue(s)
CORE-1058
Steps to test or reproduce
Further comments